thisisnic commented on code in PR #47278:
URL: https://github.com/apache/arrow/pull/47278#discussion_r2276313738
##########
r/R/dplyr-funcs-datetime.R:
##########
@@ -850,14 +850,14 @@ register_bindings_hms <- function() {
abort("All arguments must be numeric or NA_real_")
}
- total_secs <- seconds +
- Expression$create("multiply_checked", minutes, 60) +
- Expression$create("multiply_checked", hours, 3600) +
- Expression$create("multiply_checked", days, 86400)
+ total_ms <- Expression$create("multiply_checked", seconds, 1000) +
+ Expression$create("multiply_checked", minutes, 60000) +
+ Expression$create("multiply_checked", hours, 3600000) +
+ Expression$create("multiply_checked", days, 86400000)
Review Comment:
Yeah, the latter is exactly it. The thinking here was that `hms::hms()`
just has args `seconds`, `minutes`, `hours`, and `days`, and so subsecond times
would be part of seconds and either they'll happily get converted to
milliseconds, or we'll get an error if they're in the order of nanoseconds.
We could just do it and round them, but I think that would be more
problematic to do that silently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
