jonkeane commented on code in PR #47278:
URL: https://github.com/apache/arrow/pull/47278#discussion_r2269848203


##########
r/tests/testthat/test-dplyr-funcs-datetime.R:
##########
@@ -3772,22 +3772,24 @@ test_that("hms::as_hms", {
     int = c(30L, 75L),

Review Comment:
   I can't comment on the line above, but should we change that `hms_string` to 
something like: `hms_string = c("0:7:45.42", "12:34:56.57")` so that we get 
coverage for that?
   
   Or maybe we want to add in tens or ones digits to the `datetime` column?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to