aihuaxu commented on PR #455: URL: https://github.com/apache/arrow-go/pull/455#issuecomment-3185758715
> > There is a ask to create the test files from GO language and then test out from Parquet-Java side. Can you help generate the same set of the test files? > > I can do so, except for the constructions which aren't valid according to the spec as the Go implementation doesn't allow for it. > > This includes the confusion over required vs optional vs present etc. at a minimum, possibly taking @emkornfield's suggestion [here](https://github.com/apache/arrow-go/pull/455#issuecomment-3140838383) to at least add a glossary of terms or otherwise simply clarify the language based on the intent. > > Is there a script that was used to generate the test cases? Or do I need to parse the values in the JSON to figure out what should go in the files? > > In addition, where should I put the files? We generated those test files from Iceberg unit tests (https://github.com/apache/iceberg/pull/13654), not from a script. What I can think of is to expand this PR to read those files in tests and then rewrite out through GO-Variant writer logic. We can put in https://github.com/apache/parquet-testing repository. If we can have the same layout as https://github.com/apache/parquet-testing/pull/90. That will be great to make the test from Parquet-Java easier. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
