aihuaxu commented on PR #455: URL: https://github.com/apache/arrow-go/pull/455#issuecomment-3190566954
> @aihuaxu It appears all of the parquet files with Decimal values that you regenerated are inconsistent with the test cases. The values in the parquet files don't match the expected values in the variant (for example, containing `123456789` instead of `1234567890` and some other rounding differences. The original files had the correct values, but were just missing the Variant logical type.) Can you fix them please? For decimal values, the changes are expected to align with the spec - original 1234567890 should be treated as decimal8 rather than decimal4 since the values with 1~9 precision is stored as decimal4. > Also some cases haven't been given the new notes/descriptions, such as the cases which test for a missing value column (the spec wording still does not allow for the value column to be omitted) I didn't update for these test cases since missing value column can be omitted to indicate the value is null (I would like to clarify in the spec https://github.com/apache/parquet-format/pull/512/). Please take another look. I consolidate the files into one place. Sorry that I didn't notice that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
