pitrou commented on code in PR #47410:
URL: https://github.com/apache/arrow/pull/47410#discussion_r2297644611
##########
python/pyarrow/tests/test_flight.py:
##########
@@ -2536,3 +2536,28 @@ def received_headers(self, headers):
assert ("x-header-bin", b"header\x01value") in factory.headers
assert ("x-trailer", "trailer-value") in factory.headers
assert ("x-trailer-bin", b"trailer\x01value") in factory.headers
+
+
+def test_flight_dictionary_deltas_do_exchange():
+ class DeltaFlightServer(ConstantFlightServer):
+ def do_exchange(self, context, descriptor, reader, writer):
+ if descriptor.command == b'dict_deltas':
+ table = simple_dicts_table()
+ options = pa.ipc.IpcWriteOptions(emit_dictionary_deltas=True)
+ writer.begin(table.schema, options=options)
+ writer.write_table(table)
+
+ with DeltaFlightServer() as server, \
+ FlightClient(('localhost', server.port)) as client:
+
+ descriptor = flight.FlightDescriptor.for_command(b"dict_deltas")
+ writer, reader = client.do_exchange(descriptor,
Review Comment:
This doesn't check that the client-side `writer` can also emit dictionary
deltas, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
