pitrou commented on code in PR #47410:
URL: https://github.com/apache/arrow/pull/47410#discussion_r2298495172
##########
cpp/src/arrow/flight/transport_server.cc:
##########
@@ -188,71 +226,54 @@ class TransportMessageWriter final : public
FlightMessageWriter {
Status WriteMetadata(std::shared_ptr<Buffer> app_metadata) override {
FlightPayload payload{};
payload.app_metadata = app_metadata;
- return WritePayload(payload);
+ ARROW_ASSIGN_OR_RAISE(auto success, stream_->WriteData(payload));
+ if (!success) {
Review Comment:
In `WritePayload` we used to have the following error path, why are we
suddenly silencing the write error here?
```c++
if (!success) {
return MakeFlightError(FlightStatusCode::Internal,
"Could not write metadata to stream (client
disconnect?)");
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
