raulcd commented on code in PR #47410:
URL: https://github.com/apache/arrow/pull/47410#discussion_r2298518507
##########
cpp/src/arrow/flight/transport_server.cc:
##########
@@ -188,71 +226,54 @@ class TransportMessageWriter final : public
FlightMessageWriter {
Status WriteMetadata(std::shared_ptr<Buffer> app_metadata) override {
FlightPayload payload{};
payload.app_metadata = app_metadata;
- return WritePayload(payload);
+ ARROW_ASSIGN_OR_RAISE(auto success, stream_->WriteData(payload));
+ if (!success) {
Review Comment:
I am using the same logic that we are using on the client:
https://github.com/apache/arrow/blob/f8b20f131a072ef423e81b8a676f42a82255f4ec/cpp/src/arrow/flight/client.cc#L456-L464
We should return the built error after attempting to close but we should be
consistent on the client side too. Should I add the error to the client too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
