HuaHuaY commented on code in PR #47427:
URL: https://github.com/apache/arrow/pull/47427#discussion_r2301470775
##########
cpp/src/parquet/column_writer.cc:
##########
@@ -2519,29 +2520,29 @@ struct SerializeFunctor<
int64_t non_null_count = array.length() - array.null_count();
int64_t size = non_null_count * ArrowType::kByteWidth;
scratch_buffer = AllocateBuffer(ctx->memory_pool, size);
- scratch = reinterpret_cast<int64_t*>(scratch_buffer->mutable_data());
+ scratch = scratch_buffer->mutable_data();
}
- template <int byte_width>
FixedLenByteArray FixDecimalEndianness(const uint8_t* in, int64_t offset) {
- const auto* u64_in = reinterpret_cast<const int64_t*>(in);
auto out = reinterpret_cast<const uint8_t*>(scratch) + offset;
- static_assert(byte_width == 16 || byte_width == 32,
- "only 16 and 32 byte Decimals supported");
- if (byte_width == 32) {
- *scratch++ = ::arrow::bit_util::ToBigEndian(u64_in[3]);
- *scratch++ = ::arrow::bit_util::ToBigEndian(u64_in[2]);
- *scratch++ = ::arrow::bit_util::ToBigEndian(u64_in[1]);
- *scratch++ = ::arrow::bit_util::ToBigEndian(u64_in[0]);
+ if constexpr (std::is_same_v<ArrowType, ::arrow::Decimal32Type>) {
+ const auto* u32_in = reinterpret_cast<const uint32_t*>(in);
+ auto p = reinterpret_cast<uint32_t*>(scratch);
+ *p++ = ::arrow::bit_util::ToBigEndian(u32_in[0]);
+ scratch = reinterpret_cast<uint8_t*>(p);
} else {
- *scratch++ = ::arrow::bit_util::ToBigEndian(u64_in[1]);
- *scratch++ = ::arrow::bit_util::ToBigEndian(u64_in[0]);
+ const auto* u64_in = reinterpret_cast<const uint64_t*>(in);
+ auto p = reinterpret_cast<uint64_t*>(scratch);
+ for (int i = ArrowType::kByteWidth / 8 - 1; i >= 0; i--) {
Review Comment:
Or I can replace it with `if constexpr else`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
