HuaHuaY commented on code in PR #47427: URL: https://github.com/apache/arrow/pull/47427#discussion_r2302706153
########## cpp/src/parquet/arrow/schema_internal.h: ########## @@ -19,16 +19,19 @@ #include "arrow/result.h" #include "arrow/type_fwd.h" +#include "parquet/properties.h" Review Comment: `default_arrow_reader_properties()` returns `ArrowReaderProperties` which is an incomplete type here, so we can not just use forward declaration. Due to the default parameter is only used in `schema_internal.cc`, we can keep the function signature and add an overload function in `schema_internal.cc` instead. Do you prefer this solution compared to including head file? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
