wgtmac commented on code in PR #47427:
URL: https://github.com/apache/arrow/pull/47427#discussion_r2306056841
##########
cpp/src/parquet/properties.h:
##########
@@ -1126,6 +1127,18 @@ class PARQUET_EXPORT ArrowReaderProperties {
/// Return whether loading statistics as much as possible.
bool should_load_statistics() const { return should_load_statistics_; }
+ /// \brief Set whether infer Decimal32/64 from parquet.
Review Comment:
```suggestion
/// \brief Set whether to infer Decimal32/64 from Parquet decimal logical
types.
```
##########
cpp/src/parquet/properties.h:
##########
@@ -1126,6 +1127,18 @@ class PARQUET_EXPORT ArrowReaderProperties {
/// Return whether loading statistics as much as possible.
bool should_load_statistics() const { return should_load_statistics_; }
+ /// \brief Set whether infer Decimal32/64 from parquet.
+ ///
+ /// Default is false.
+ void set_smallest_decimal_enabled(bool smallest_decimal_enable) {
+ smallest_decimal_enabled_ = smallest_decimal_enable;
+ }
+ /// \brief Return whether to infer Decimal32/64 from parquet.
Review Comment:
```suggestion
/// \brief Return whether to infer Decimal32/64 from Parquet decimal
logical types.
```
##########
cpp/src/parquet/arrow/arrow_reader_writer_test.cc:
##########
@@ -795,9 +795,10 @@ class ParquetIOTestBase : public ::testing::Test {
class TestReadDecimals : public ParquetIOTestBase {
public:
- void CheckReadFromByteArrays(const std::shared_ptr<const LogicalType>&
logical_type,
- const std::vector<std::vector<uint8_t>>& values,
- const Array& expected) {
+ void CheckReadFromByteArrays(
+ const std::shared_ptr<const LogicalType>& logical_type,
+ const std::vector<std::vector<uint8_t>>& values, const Array& expected,
+ ArrowReaderProperties properties = default_arrow_reader_properties()) {
Review Comment:
```suggestion
const ArrowReaderProperties& properties =
default_arrow_reader_properties()) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
