eitsupi commented on code in PR #3381:
URL: https://github.com/apache/arrow-adbc/pull/3381#discussion_r2314257268
##########
rust/core/src/error.rs:
##########
@@ -22,6 +22,10 @@ use std::{ffi::NulError, fmt::Display};
use arrow_schema::ArrowError;
+use crate::constants;
+
+pub type AdbcStatusCode = u8;
Review Comment:
After checking, I think the name comes from the one of the same name in the
`adbc.h` file.
https://github.com/apache/arrow-adbc/blob/cae6bd168b976a9916cead99725dd11d56838b3c/c/include/arrow-adbc/adbc.h#L175-L176
Perhaps it should be in the `constants` module instead of the `error` module?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
