felipecrv commented on code in PR #3381:
URL: https://github.com/apache/arrow-adbc/pull/3381#discussion_r2314594781
##########
rust/driver_manager/src/lib.rs:
##########
@@ -119,13 +119,14 @@ use arrow_array::{Array, RecordBatch, RecordBatchReader,
StructArray};
use toml::de::DeTable;
use adbc_core::{
- error::{Error, Result, Status},
+ constants,
+ error::{AdbcStatusCode, Error, Result, Status},
options::{self, AdbcVersion, InfoCode, OptionValue},
- LoadFlags, PartitionedResult, LOAD_FLAG_ALLOW_RELATIVE_PATHS,
LOAD_FLAG_SEARCH_ENV,
- LOAD_FLAG_SEARCH_SYSTEM, LOAD_FLAG_SEARCH_USER,
+ Connection, Database, Driver, LoadFlags, Optionable, PartitionedResult,
Statement,
+ LOAD_FLAG_ALLOW_RELATIVE_PATHS, LOAD_FLAG_SEARCH_ENV,
LOAD_FLAG_SEARCH_SYSTEM,
+ LOAD_FLAG_SEARCH_USER,
};
-use adbc_core::{ffi, ffi::driver_method, Optionable};
-use adbc_core::{Connection, Database, Driver, Statement};
+use adbc_ffi::driver_method;
Review Comment:
You're right. It would conflict with `std::ffi` in the reader's mind. Leave
the `adbc_ffi` then. Fine by me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
