kou commented on code in PR #47484:
URL: https://github.com/apache/arrow/pull/47484#discussion_r2323636309
##########
ci/scripts/install_vcpkg.sh:
##########
@@ -42,6 +43,11 @@ pushd "${vcpkg_destination}"
git checkout "${vcpkg_version}"
+if [ -f "${vcpkg_patch}" ]; then
Review Comment:
We don't need this `if` because we always use the vcpkg patch.
The vcpkg ports patch may not exist when a caller specify a vcpkg ports
patch path.
##########
ci/docker/python-wheel-windows-test-vs2022-base.dockerfile:
##########
@@ -33,10 +33,8 @@ RUN `
curl -SL --output vs_buildtools.exe
https://aka.ms/vs/17/release/vs_buildtools.exe `
&& (start /w vs_buildtools.exe --quiet --wait --norestart --nocache `
--installPath "%ProgramFiles(x86)%\Microsoft Visual
Studio\2022\BuildTools" `
- --add Microsoft.VisualStudio.Component.VC.CoreBuildTools `
- --add Microsoft.VisualStudio.Component.VC.Tools.x86.x64 `
- --add Microsoft.VisualStudio.Component.Windows10SDK.20348 `
- --add Microsoft.VisualStudio.Component.VC.CMake.Project `
+ --includeRecommended ^ `
Review Comment:
I think that
https://hub.docker.com/r/apache/arrow-dev/tags?name=windows&ordering=-name have
the uploaded images but no images exist...
`docker compose images` may show the size of built images.
BTW, I think that we should use `--includeRecommended` even if it increases
image size. We don't want to maintain Visual Studio components...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
