pitrou commented on code in PR #47484:
URL: https://github.com/apache/arrow/pull/47484#discussion_r2324498160
##########
ci/docker/python-wheel-windows-test-vs2022-base.dockerfile:
##########
@@ -33,10 +33,8 @@ RUN `
curl -SL --output vs_buildtools.exe
https://aka.ms/vs/17/release/vs_buildtools.exe `
&& (start /w vs_buildtools.exe --quiet --wait --norestart --nocache `
--installPath "%ProgramFiles(x86)%\Microsoft Visual
Studio\2022\BuildTools" `
- --add Microsoft.VisualStudio.Component.VC.CoreBuildTools `
- --add Microsoft.VisualStudio.Component.VC.Tools.x86.x64 `
- --add Microsoft.VisualStudio.Component.Windows10SDK.20348 `
- --add Microsoft.VisualStudio.Component.VC.CMake.Project `
+ --includeRecommended ^ `
Review Comment:
Ouch! On the one hand, I agree with @kou that "We don't want to maintain
Visual Studio components", on the other hand, a 6 GB increase is a considerable
increase... This translates directly into larger CI times
(pulling/decompressing an image can take quite a lot of time) and also larger
times on developer's machines (though I suspect it's quite rare to reproduce
the Windows manylinux setup on a development machine).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
