raulcd commented on code in PR #47484:
URL: https://github.com/apache/arrow/pull/47484#discussion_r2324685633
##########
ci/docker/python-wheel-windows-test-vs2022-base.dockerfile:
##########
@@ -33,10 +33,8 @@ RUN `
curl -SL --output vs_buildtools.exe
https://aka.ms/vs/17/release/vs_buildtools.exe `
&& (start /w vs_buildtools.exe --quiet --wait --norestart --nocache `
--installPath "%ProgramFiles(x86)%\Microsoft Visual
Studio\2022\BuildTools" `
- --add Microsoft.VisualStudio.Component.VC.CoreBuildTools `
- --add Microsoft.VisualStudio.Component.VC.Tools.x86.x64 `
- --add Microsoft.VisualStudio.Component.Windows10SDK.20348 `
- --add Microsoft.VisualStudio.Component.VC.CMake.Project `
+ --includeRecommended ^ `
Review Comment:
I agree that maintaining the individual components isn't great.
Another small annoyance of installing all recommended is that it takes
double to install, from ~5.5 minutes to ~11 minutes.
I am testing updating individual components, and from my initial test, it
seems that updating the Windows 11 SDK component might be enough, moving the
installation back to ~6 minutes and with an installation size of:
```
ghcr.io/ursacomputing/arrow
python-wheel-windows-vs2022-base-vcpkg-f7423ee180c4b7f40d43402c2feb3859161ef625-2025-09-04
9.69GB
```
This is with the following diff, so just updating the Windows SDK is a +2GB
image size:
```diff
diff --git a/ci/docker/python-wheel-windows-vs2022-base.dockerfile
b/ci/docker/python-wheel-windows-vs2022-base.dockerfile
index 7f683487a8..99dd27b987 100644
--- a/ci/docker/python-wheel-windows-vs2022-base.dockerfile
+++ b/ci/docker/python-wheel-windows-vs2022-base.dockerfile
@@ -67,7 +67,7 @@ RUN `
--installPath "%ProgramFiles(x86)%\Microsoft Visual
Studio\2022\BuildTools" `
--add Microsoft.VisualStudio.Component.VC.CoreBuildTools `
--add Microsoft.VisualStudio.Component.VC.Tools.x86.x64 `
- --add Microsoft.VisualStudio.Component.Windows10SDK.20348 `
+ --add Microsoft.VisualStudio.Component.Windows11SDK.26100 `
--add Microsoft.VisualStudio.Component.VC.CMake.Project `
|| IF "%ERRORLEVEL%"=="3010" EXIT 0) `
&& del /q vs_buildtools.exe
```
The wheels take a long time, so I'll report back once the build finishes and
whether the wheel tests issue is also fixed updating the Windows SDK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
