andishgar commented on PR #47586: URL: https://github.com/apache/arrow/pull/47586#issuecomment-3376022605
**@pitrou** Thanks for the feedback! > Ok, I tried to read this PR but this is making many changes that do not seem related to the task of fixing a simple bug. > Can we have a more minimal set of changes? The issue is that the current zero-checking logic is incorrect across all sparse tensor creation paths, and that can lead to memory issues when tensors are created from negative zero values. So the fix touches several places that share this logic. Do you think it would still make sense to split it further? (This PR is already a breakdown of [a larger patch](https://github.com/apache/arrow/issues/47520#issuecomment-3298699836) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
