andishgar commented on code in PR #47586:
URL: https://github.com/apache/arrow/pull/47586#discussion_r2414117122
##########
cpp/src/arrow/tensor/coo_converter.cc:
##########
@@ -220,7 +265,8 @@ class SparseCOOTensorConverter : private
SparseTensorConverterMixin {
indices_shape, indices_strides);
ARROW_ASSIGN_OR_RAISE(sparse_index, SparseCOOIndex::Make(coords, true));
data = std::move(values_buffer);
-
+ DCHECK_OK((ValidateSparseCooTensorCreation<ValueType,
IndexType>(*sparse_index, *data,
Review Comment:
>Perhaps we can make this a Validate method on the sparse tensor class
instead?
I should first address this
[issue](https://github.com/apache/arrow/issues/47613) to make sure there is a
limited type for the CSF tensor format.
@rok, is it okay to address this
[issue](https://github.com/apache/arrow/issues/47613) here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
