amoeba opened a new pull request, #3591: URL: https://github.com/apache/arrow-adbc/pull/3591
I started adding a vcpkg preset for Windows and then saw https://github.com/apache/arrow-adbc/pull/2858 which was most of the way there. I wanted to polish things up a bit so I'm opening a new PR and crediting @iife as a co-author since I used parts of their original PR. This PR includes: - Adds two new CMake presets that use vcpkg (debug, release) - Tweaks the GoUtils.cmake to create import libs for Go-based drivers, closing https://github.com/apache/arrow-adbc/issues/2846 - Adds a CI job to build everything with vcpkg and test just what we can easily test on CI. There are a few CI-only test segfaults I need to track down still. Only 6 driver manager tests fail for me locally. The new CI job includes caching of vcpkgs tests (I've tested this) - Added ignores for some MSVC warnings, fixed code in other places. **Each of these changes are in separate commits to make it easier to review.** - Adds a vcpkg.json to the sqlite driver just for parity with the postgresql driver - Co-Authored-By: Alamiri, Ali <[email protected]> Closes https://github.com/apache/arrow-adbc/issues/2846 Ref https://github.com/apache/arrow-adbc/issues/2557 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
