amoeba commented on code in PR #3591:
URL: https://github.com/apache/arrow-adbc/pull/3591#discussion_r2443715995
##########
c/cmake_modules/GoUtils.cmake:
##########
@@ -184,36 +198,85 @@ function(add_go_lib GO_MOD_DIR GO_LIBNAME)
list(APPEND GO_ENV_VARS "GOARCH=arm64")
endif()
- add_custom_command(OUTPUT "${LIBOUT_SHARED}.${ADBC_FULL_SO_VERSION}"
Review Comment:
Reviewer note: The rest of this file I used a combination of Claude Code and
the previous PR and comments therein to come up with something that worked. I
want to go back over this tomorrow with fresh eyes but I thought I'd point it
out in case it helps review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
