amoeba commented on code in PR #3591:
URL: https://github.com/apache/arrow-adbc/pull/3591#discussion_r2443714148
##########
c/driver/sqlite/CMakeLists.txt:
##########
@@ -68,6 +68,16 @@ foreach(LIB_TARGET ${ADBC_LIBRARIES})
if(NOT ADBC_DEFINE_COMMON_ENTRYPOINTS)
target_compile_definitions(${LIB_TARGET} PRIVATE
${ADBC_TARGET_COMPILE_DEFINITIONS})
endif()
+
+ # On Windows, install sqlite3.dll alongside the driver
+ if(WIN32 AND CMAKE_VERSION VERSION_GREATER_EQUAL "3.21")
Review Comment:
This whole block was mainly to copy runtime deps, I came up with using
RUNTIME_DEPENDENCY_SET like this with LLM help and RUNTIME_DEPENDENCY_SET is
3.21, see https://cmake.org/cmake/help/latest/command/install.html. I tried
something similar before this and didn't get something working.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
