amoeba commented on code in PR #3591:
URL: https://github.com/apache/arrow-adbc/pull/3591#discussion_r2443814812
##########
c/driver_manager/CMakeLists.txt:
##########
@@ -98,9 +98,15 @@ if(ADBC_BUILD_TESTS)
target_compile_features(adbc-driver-manager-test PRIVATE cxx_std_17)
if(ADBC_DRIVER_SQLITE)
- target_compile_definitions(adbc-driver-manager-test
- PRIVATE
ADBC_DRIVER_MANAGER_TEST_LIB="${CMAKE_BINARY_DIR}/driver/sqlite/libadbc_driver_sqlite${CMAKE_SHARED_LIBRARY_SUFFIX}"
- )
+ if(WIN32)
+ target_compile_definitions(adbc-driver-manager-test
+ PRIVATE
ADBC_DRIVER_MANAGER_TEST_LIB="${CMAKE_BINARY_DIR}/driver/sqlite/adbc_driver_sqlite${CMAKE_SHARED_LIBRARY_SUFFIX}"
+ )
+ else()
+ target_compile_definitions(adbc-driver-manager-test
+ PRIVATE
ADBC_DRIVER_MANAGER_TEST_LIB="${CMAKE_BINARY_DIR}/driver/sqlite/libadbc_driver_sqlite${CMAKE_SHARED_LIBRARY_SUFFIX}"
+ )
+ endif()
Review Comment:
Nice, thanks. Fixed in 27db1e641aa3584898aebb4bcba41cd66daac7b3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
