alinaliBQ commented on code in PR #47971:
URL: https://github.com/apache/arrow/pull/47971#discussion_r2467480515
##########
cpp/src/arrow/flight/sql/odbc/tests/odbc_test_suite.cc:
##########
@@ -144,11 +148,14 @@ std::wstring
FlightSQLODBCRemoteTestBase::GetQueryAllDataTypes() {
return wsql;
}
-void FlightSQLODBCRemoteTestBase::SetUp() {
+void ODBCRemoteTestBase::SetUp() {
if (arrow::internal::GetEnvVar(kTestConnectStr.data()).ValueOr("").empty()) {
GTEST_SKIP() << "Skipping test: kTestConnectStr not set";
}
+}
+void FlightSQLODBCRemoteTestBase::SetUp() {
+ ODBCRemoteTestBase::SetUp();
this->Connect();
Review Comment:
This change causes test failure because having `GTEST_SKIP` in `SetUp`
doesn't cause the subsequent `Connect` call to be skipped. We are looking into
it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
