alinaliBQ commented on code in PR #47971:
URL: https://github.com/apache/arrow/pull/47971#discussion_r2504807359
##########
cpp/src/arrow/flight/sql/odbc/odbc_impl/attribute_utils.h:
##########
@@ -17,16 +17,15 @@
#pragma once
-#include <arrow/flight/sql/odbc/odbc_impl/diagnostics.h>
-#include <arrow/flight/sql/odbc/odbc_impl/exceptions.h>
-#include <arrow/flight/sql/odbc/odbc_impl/platform.h>
#include <sql.h>
#include <sqlext.h>
#include <algorithm>
#include <cstring>
#include <memory>
-
-#include <arrow/flight/sql/odbc/odbc_impl/encoding_utils.h>
+#include "arrow/flight/sql/odbc/odbc_impl/diagnostics.h"
+#include "arrow/flight/sql/odbc/odbc_impl/encoding_utils.h"
+#include "arrow/flight/sql/odbc/odbc_impl/exceptions.h"
+#include "arrow/flight/sql/odbc/odbc_impl/platform.h"
namespace ODBC {
Review Comment:
I have created issue https://github.com/apache/arrow/issues/48083,
@justing-bq please link this issue in the code, thanks!
```
GH-48083 TODO: replace `namespace ODBC` with `namespace
arrow::flight::sql::odbc`
```
##########
.github/workflows/cpp.yml:
##########
@@ -310,7 +310,7 @@ jobs:
ARROW_DATASET: ON
ARROW_FLIGHT: ON
ARROW_FLIGHT_SQL: ON
- ARROW_FLIGHT_SQL_ODBC: ON
+ ARROW_FLIGHT_SQL_ODBC: OFF
ARROW_GANDIVA: ON
Review Comment:
As discussed in https://github.com/apache/arrow/issues/48019, we will try to
enable ODBC on MSVC, so I am removing ODBC build from MinGW here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
