justing-bq commented on code in PR #47971:
URL: https://github.com/apache/arrow/pull/47971#discussion_r2505571508
##########
cpp/src/arrow/flight/sql/odbc/odbc_impl/spi/connection.h:
##########
@@ -32,13 +32,13 @@ namespace arrow::flight::sql::odbc {
/// \brief Case insensitive comparator
struct CaseInsensitiveComparator {
- bool operator()(const std::string_view& s1, const std::string_view& s2)
const {
+ bool operator()(const std::string& s1, const std::string& s2) const {
return boost::lexicographical_compare(s1, s2, boost::is_iless());
}
};
// PropertyMap is case-insensitive for keys.
-typedef std::map<std::string_view, std::string, CaseInsensitiveComparator>
PropertyMap;
+typedef std::map<std::string, std::string, CaseInsensitiveComparator>
PropertyMap;
Review Comment:
I've changed it to a transparent comparator and adjusted all the unnecessary
std::string() wrapping.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
