jhrotko commented on code in PR #892:
URL: https://github.com/apache/arrow-java/pull/892#discussion_r2474229980
##########
vector/src/main/java/org/apache/arrow/vector/complex/LargeListVector.java:
##########
@@ -661,6 +667,11 @@ public TransferImpl(Field field, BufferAllocator
allocator, CallBack callBack) {
this(new LargeListVector(field, allocator, callBack));
}
+ public TransferImpl(LargeListVector to, ExtensionTypeWriterFactory
writerFactory) {
Review Comment:
This solution would break some cases in Dremio. With this commit design we
would need to check if it is necessary a factory or not before calling the
copyfrom, because we would hit a UnsupportedException for BaseValueVectors.
Ideally this extension factory shouldn't exist at this level. We have
Timestamp, Uuid and Variant in Dremio that are new Extension types and the
implementations should "live" in arrow instead and we need to pass the
DremioExtensionFactory while doing this transfer with the current design. I am
also wondering if this factory responsability should be from the extension type
itself and not for all types. I am still thinking about a better solution but I
am also a bit reluctant to change the current design/API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
