jhrotko commented on code in PR #892:
URL: https://github.com/apache/arrow-java/pull/892#discussion_r2479277132
##########
vector/src/main/codegen/templates/ComplexCopier.java:
##########
@@ -115,13 +108,11 @@ private static void writeValue(FieldReader reader,
FieldWriter writer, Extension
}
break;
case EXTENSIONTYPE:
- if (extensionTypeWriterFactory == null) {
- throw new IllegalArgumentException("Must provide
ExtensionTypeWriterFactory");
- }
if (reader.isSet()) {
Object value = reader.readObject();
if (value != null) {
- writer.addExtensionTypeWriterFactory(extensionTypeWriterFactory);
+ ExtensionTypeWriterFactory writerFactory =
reader.getExtensionTypeWriterFactory();
Review Comment:
This is the key change: now the responsibility comes from the reader instead
of passing down the factory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
