jhrotko commented on code in PR #892: URL: https://github.com/apache/arrow-java/pull/892#discussion_r2513830370
########## vector/src/main/java/org/apache/arrow/vector/complex/impl/ExtensionTypeWriterFactory.java: ########## Review Comment: I we decide to move forward with this design it's going to be a breaking change because the factory pattern was completely replaced, not deprecated alongside the new pattern. This will require users to migrate. Fortunately, the migration will be easy: Extension types must implement `getNewFieldWriter()` method and Extension holders need to implement the `type()` method as well and remove all factory references. I can provide a better migration guide in the PR description -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
