axreldable commented on code in PR #885:
URL: https://github.com/apache/arrow-java/pull/885#discussion_r2484819141


##########
vector/src/test/java/org/apache/arrow/vector/TestMapVector.java:
##########


Review Comment:
   @lidavidm , I've implemented a separate unit test for `fixedSizeBinary`. 
   
   However, I came across an issue. When I call 
`writer.key().fixedSizeBinary()` for the first time, it fails with NPE, as it 
falls back to `NullableStructWriter` which 
[requires](https://github.com/apache/arrow-java/blob/main/vector/src/main/codegen/templates/StructWriters.java#L338)
 writer to be not-null (checkout the 
`testFixedSizeBinaryWriterInitializationError` test).
   It work when I first initialize writers for both `key` and `value` fields 
with other writes, e.g. `bigInt` (checkout `testFixedSizeBinaryWriter` test).
   
    Could you help me here? What would be the right way to initialize writes 
for `key` and `value` fields for the `UnionMapWriter`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to