justing-bq commented on code in PR #47971:
URL: https://github.com/apache/arrow/pull/47971#discussion_r2505573132
##########
cpp/src/arrow/flight/sql/odbc/odbc_impl/odbc_connection.h:
##########
@@ -75,8 +75,12 @@ class ODBCConnection : public ODBCHandle<ODBCConnection> {
inline bool IsOdbc2Connection() const { return is_2x_connection_; }
- /// @return the DSN or empty string if Driver was used.
- static std::string GetPropertiesFromConnString(
+ /// @return the DSN or an empty string if the DSN is not found or is found
after the
+ /// driver
Review Comment:
Done.
##########
cpp/src/arrow/flight/sql/odbc/odbc_api.cc:
##########
@@ -31,6 +31,11 @@
#include "arrow/flight/sql/odbc/odbc_impl/spi/connection.h"
#include "arrow/util/logging.h"
+#if defined _WIN32
+// For displaying DSN Window
+# include "arrow/flight/sql/odbc/odbc_impl/system_dsn.h"
+#endif
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
