rmnskb commented on PR #48085: URL: https://github.com/apache/arrow/pull/48085#issuecomment-3505533407
@pitrou @AlenkaF @rok Sorry for pinging like this, I wanted to understand the scope correctly. So far, I went with the most straightforward implementation and added dunders for all operations that were listed [in the compute docs](https://arrow.apache.org/docs/python/api/compute.html#arithmetic-functions) and had respective dunders available. Do you think this implementation is enough or should I go for other dunders as well, e.g bitwise operations? After reviewing the original discussion, I've seen @jorisvandenbossche suggesting checked versions of the functions, I think I will go with them as well. Regarding the documentation: 1. Should I add docstrings to dunder methods? Given that user won't see them in their IDE, for example. 2. Should the documentation for arrays/scalars be updated to reflect that the native operators are now supported? Thanks for your input! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
