rok commented on PR #48085: URL: https://github.com/apache/arrow/pull/48085#issuecomment-3518053328
Sorry for late reply @rmnskb. I think all dunders that semantically map to our existing kernels are fair game! I'm not sure what these would be, but the set you have now looks decently sized. > Should I add docstrings to dunder methods? Given that user won't see them in their IDE, for example. We might be able to add docstrings via type annotations. Or perhaps it's possible to copy them at runtime from the respective kernels? (unsure that is possible). In any case we probably don't want to duplicate docstrings in general. > Should the documentation for arrays/scalars be updated to reflect that the native operators are now supported? Yes, that would be good to have! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
