lidavidm commented on code in PR #892:
URL: https://github.com/apache/arrow-java/pull/892#discussion_r2539967588
##########
vector/src/main/codegen/templates/PromotableWriter.java:
##########
@@ -540,18 +543,25 @@ public void writeLargeVarChar(String value) {
getWriter(MinorType.LARGEVARCHAR).writeLargeVarChar(value);
}
+ protected ArrowType lastExtensionType;
+
@Override
public void writeExtension(Object value) {
Review Comment:
Is there not a way to stash the extension type instance?
> I believe they do when there's no confusion about type/representation. But
here we are relying on lastExtensionType to be set first via getWriter()
It seems even before it implicitly was stashed somehow? Is there not a way
we can explicitly stash it? (I'd also be curious why this didn't seem to apply
to other parametrized types?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
