lidavidm commented on code in PR #892:
URL: https://github.com/apache/arrow-java/pull/892#discussion_r2541508172
##########
vector/src/main/codegen/templates/PromotableWriter.java:
##########
@@ -540,18 +543,25 @@ public void writeLargeVarChar(String value) {
getWriter(MinorType.LARGEVARCHAR).writeLargeVarChar(value);
}
+ protected ArrowType lastExtensionType;
+
@Override
public void writeExtension(Object value) {
Review Comment:
Ah...I'd kind of argue that was a weird decision by the union writer (it
really shouldn't assume types correspond to type codes (also see
https://github.com/apache/arrow-java/issues/108)), but I guess at this point
it's unavoidable, so this API will have to do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
