xxlaykxx commented on code in PR #892:
URL: https://github.com/apache/arrow-java/pull/892#discussion_r2541324695
##########
vector/src/main/codegen/templates/PromotableWriter.java:
##########
@@ -540,18 +543,25 @@ public void writeLargeVarChar(String value) {
getWriter(MinorType.LARGEVARCHAR).writeLargeVarChar(value);
}
+ protected ArrowType lastExtensionType;
+
@Override
public void writeExtension(Object value) {
Review Comment:
> Yes, though now I have to question why the type has to be provided twice.
It's for support UnionVector/Writer - because Union could use different
vectors inside and it's possible that several impl's of ExtensionType could be
used at the same time. From Arrow perspective, they all will be
ExtensionVector/Writer - so for the correct determination of the
extensionWriter should pass the ArrowType that will be unique
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
