alamb commented on code in PR #8898:
URL: https://github.com/apache/arrow-rs/pull/8898#discussion_r2547884042
##########
parquet/src/encryption/decrypt.rs:
##########
@@ -582,7 +582,7 @@ impl PartialEq for FileDecryptor {
impl HeapSize for FileDecryptor {
fn heap_size(&self) -> usize {
self.decryption_properties.heap_size()
- + (Arc::clone(&self.footer_decryptor) as Arc<dyn
HeapSize>).heap_size()
Review Comment:
I guess what I am confused about is why we have a `dyn Heapsize` in the
first place -- we know the exact type of the decryptor:
https://github.com/apache/arrow-rs/blob/main/parquet/src/encryption/decrypt.rs#L563
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
