adamreeve commented on code in PR #8898:
URL: https://github.com/apache/arrow-rs/pull/8898#discussion_r2547900518
##########
parquet/src/encryption/decrypt.rs:
##########
@@ -582,7 +582,7 @@ impl PartialEq for FileDecryptor {
impl HeapSize for FileDecryptor {
fn heap_size(&self) -> usize {
self.decryption_properties.heap_size()
- + (Arc::clone(&self.footer_decryptor) as Arc<dyn
HeapSize>).heap_size()
Review Comment:
The decryptor referenced here is actually an `Arc<dyn BlockDecryptor>`:
https://github.com/apache/arrow-rs/blob/ed9efe78e4cc958cc96707557818e754419debb0/parquet/src/encryption/decrypt.rs#L565
We do only have one implementation of that trait at the moment though, but
the original plan was to also support an AES-GCM-CTR decryptor
(https://github.com/apache/arrow-rs/issues/7258)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
