IIFE commented on PR #2858: URL: https://github.com/apache/arrow-adbc/pull/2858#issuecomment-3672513116
@lidavidm I have now sorted the python build issue. I'm not sure why exactly, but using the gcc on windows-latest from `c:\mingw64` seems to be causing the issue. When instead I download latest gcc from `winlibs`, everything works fine. So I added a step to the python build job that uses the `winlibs` version. It defaults to latest from `winlibs`, but the github action step can allow us to pin the gcc version if we wanted to. Additionally I have removed the hard-coded `"generator": "Visual Studio 17 2022"` from the preset, so that whatever default generator is used by the build system. This will simplify integration with vcpkg to build and install arrow-adbc using vcpkg port file. Also made the change to pin the msbuild step, but that doesn't seem to have made a difference? adbc driver manager has been copied to the go folder to fix pre-commit. I think this PR is now in a ready state? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
