amoeba commented on code in PR #2858:
URL: https://github.com/apache/arrow-adbc/pull/2858#discussion_r2633028315
##########
.github/workflows/native-windows.yml:
##########
@@ -209,7 +209,7 @@ jobs:
with:
path: ~/conda_pkgs_dir
key: conda-${{ runner.os }}-${{ steps.get-date.outputs.today }}-${{
env.CACHE_NUMBER }}-${{ hashFiles('ci/**') }}
- - uses:
conda-incubator/setup-miniconda@835234971496cad1653abb28a638a281cf32541f #
v3.2.0
+ - uses:
conda-incubator/setup-miniconda@835234971496cad1653abb28a638a281cf32541f #
v3.2.0
Review Comment:
can you please revert this change?
##########
.github/workflows/native-windows.yml:
##########
@@ -137,7 +137,7 @@ jobs:
with:
path: ~/conda_pkgs_dir
key: conda-${{ runner.os }}-${{ steps.get-date.outputs.today }}-${{
env.CACHE_NUMBER }}-${{ hashFiles('ci/**') }}
- - uses:
conda-incubator/setup-miniconda@835234971496cad1653abb28a638a281cf32541f #
v3.2.0
+ - uses:
conda-incubator/setup-miniconda@835234971496cad1653abb28a638a281cf32541f #
v3.2.0
Review Comment:
can you please revert this change?
##########
.github/workflows/native-windows.yml:
##########
@@ -81,7 +81,7 @@ jobs:
with:
path: ~/conda_pkgs_dir
key: conda-${{ runner.os }}-${{ steps.get-date.outputs.today }}-${{
env.CACHE_NUMBER }}-${{ hashFiles('ci/**') }}
- - uses:
conda-incubator/setup-miniconda@835234971496cad1653abb28a638a281cf32541f #
v3.2.0
+ - uses:
conda-incubator/setup-miniconda@835234971496cad1653abb28a638a281cf32541f #
v3.2.0
Review Comment:
can you please revert this change?
##########
.github/workflows/native-windows.yml:
##########
@@ -31,7 +31,7 @@ on:
- ".github/workflows/native-windows.yml"
push:
branches-ignore:
- - 'dependabot/**'
+ - "dependabot/**"
Review Comment:
can you please revert this change?
##########
.github/workflows/native-windows.yml:
##########
@@ -260,6 +260,18 @@ jobs:
with:
fetch-depth: 0
persist-credentials: false
+ - uses: bwoodsend/setup-winlibs-action@v1
Review Comment:
```suggestion
- uses:
bwoodsend/setup-winlibs-action@ceefd070f6288838003797de3b06d7bc01e52842 # v1.16
```
##########
.github/workflows/native-windows.yml:
##########
@@ -273,7 +285,8 @@ jobs:
with:
path: ~/conda_pkgs_dir
key: conda-${{ runner.os }}-${{ steps.get-date.outputs.today }}-${{
env.CACHE_NUMBER }}-${{ hashFiles('ci/**') }}
- - uses:
conda-incubator/setup-miniconda@835234971496cad1653abb28a638a281cf32541f #
v3.2.0
+
+ - uses:
conda-incubator/setup-miniconda@835234971496cad1653abb28a638a281cf32541f #
v3.2.0
Review Comment:
can you please revert this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
