seberg commented on code in PR #48391:
URL: https://github.com/apache/arrow/pull/48391#discussion_r2671794922
##########
python/pyarrow/src/arrow/python/numpy_to_arrow.cc:
##########
@@ -338,6 +369,16 @@ Status NumPyConverter::Convert() {
return Status::OK();
}
+ if (IsStringDType(dtype_)) {
+#if NPY_ABI_VERSION >= 0x02000000
+ RETURN_NOT_OK(ConvertStringDType());
+ return Status::OK();
+#else
+ return Status::NotImplemented(
+ "NumPy StringDType requires building PyArrow with NumPy >= 2.0");
Review Comment:
That is correct, the NumPy C-API import will just barf at you and refuse to
run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
