pitrou commented on code in PR #48391:
URL: https://github.com/apache/arrow/pull/48391#discussion_r2671804011
##########
python/pyarrow/src/arrow/python/numpy_to_arrow.cc:
##########
@@ -74,6 +77,27 @@ using internal::NumPyTypeSize;
namespace {
+#if NPY_ABI_VERSION >= 0x02000000
Review Comment:
We don't seem to define `NPY_FEATURE_VERSION` anywhere, so that does mean
the 2.0 macros are not available in the NumPy headers? If we define
`NPY_FEATURE_VERSION` to 2.0, does that mean that the produced extension with
not be compiled with NumPy 1.x?
It would be nice if these interactions were made clearer somewhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
