seberg commented on code in PR #48391:
URL: https://github.com/apache/arrow/pull/48391#discussion_r2671813250
##########
python/pyarrow/src/arrow/python/numpy_to_arrow.cc:
##########
@@ -74,6 +77,27 @@ using internal::NumPyTypeSize;
namespace {
+#if NPY_ABI_VERSION >= 0x02000000
Review Comment:
> If we define NPY_FEATURE_VERSION to 2.0, does that mean that the produced
extension with not be compiled with NumPy 1.x?
Yeah, except what you define would be `NPY_TARGET_VERSION`. Don't ask me why
I used a different name, it was probably silly, but it is what we have now.
I think `NPY_TARGET_VERSION` is described. But this way of using future API
conditionally is not (the only place is that `npy_2_compat.h` header in NumPy
itself uses similar conditionals).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
