HyukjinKwon commented on code in PR #48792:
URL: https://github.com/apache/arrow/pull/48792#discussion_r2677846443
##########
cpp/src/arrow/engine/substrait/expression_internal.cc:
##########
@@ -1249,42 +1249,52 @@ Result<std::unique_ptr<substrait::Expression>>
MakeListElementReference(
Result<std::unique_ptr<substrait::Expression::ScalarFunction>>
EncodeSubstraitCall(
const SubstraitCall& call, ExtensionSet* ext_set,
const ConversionOptions& conversion_options) {
+
+ auto scalar_fn =
+ std::make_unique<substrait::Expression::ScalarFunction>();
+
+ // Encode function ONCE per scalar function (FIX)
Review Comment:
Feel free to update the PR description. I would want to follow how you
tested and verify the PR 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
