alamb commented on code in PR #9155:
URL: https://github.com/apache/arrow-rs/pull/9155#discussion_r2686680785
##########
arrow-buffer/src/builder/boolean.rs:
##########
@@ -247,14 +265,24 @@ impl BooleanBufferBuilder {
self.buffer.as_slice_mut()
}
- /// Creates a [`BooleanBuffer`]
+ /// Creates a [`BooleanBuffer`].
+ ///
+ /// Use [`Self::build`] when you don't need to reuse this builder.
#[inline]
pub fn finish(&mut self) -> BooleanBuffer {
let buf = std::mem::replace(&mut self.buffer, MutableBuffer::new(0));
let len = std::mem::replace(&mut self.len, 0);
BooleanBuffer::new(buf.into(), 0, len)
}
+ /// Builds a [`BooleanBuffer`] without resetting the builder.
+ ///
+ /// This consumes the builder. Use [`Self::finish`] to reuse it.
+ #[inline]
+ pub fn build(self) -> BooleanBuffer {
Review Comment:
most builders have a `build` method. The fact that the Buffer builders do
not is a small source of API friction I would like to remove
##########
arrow-buffer/src/builder/boolean.rs:
##########
@@ -247,14 +265,24 @@ impl BooleanBufferBuilder {
self.buffer.as_slice_mut()
}
- /// Creates a [`BooleanBuffer`]
+ /// Creates a [`BooleanBuffer`].
+ ///
+ /// Use [`Self::build`] when you don't need to reuse this builder.
#[inline]
pub fn finish(&mut self) -> BooleanBuffer {
let buf = std::mem::replace(&mut self.buffer, MutableBuffer::new(0));
let len = std::mem::replace(&mut self.len, 0);
BooleanBuffer::new(buf.into(), 0, len)
}
+ /// Builds a [`BooleanBuffer`] without resetting the builder.
+ ///
+ /// This consumes the builder. Use [`Self::finish`] to reuse it.
+ #[inline]
+ pub fn build(self) -> BooleanBuffer {
Review Comment:
most builders have a `build` method. The fact that the `*Buffer` builders in
the crate do not is a small source of API friction I would like to remove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
