alamb commented on code in PR #9155:
URL: https://github.com/apache/arrow-rs/pull/9155#discussion_r2686683680
##########
arrow-buffer/src/builder/null.rs:
##########
@@ -17,19 +17,22 @@
use crate::{BooleanBufferBuilder, MutableBuffer, NullBuffer};
-/// Builder for creating [`NullBuffer`]
+/// Builder for creating [`NullBuffer`]s (bitmaps indicating validity/nulls).
+///
+/// # See also
+/// * [`BooleanBufferBuilder`] for a lower-level bitmap builder.
+/// * [`Self::allocated_size`] for the current memory allocated by the builder.
///
/// # Performance
///
-/// This builder only materializes the buffer when we append `false`.
-/// If you only append `true`s to the builder, what you get will be
-/// `None` when calling [`finish`](#method.finish).
+/// This builder only materializes the buffer when null values (`false`) are
Review Comment:
drive by wording cleanup
##########
arrow-buffer/src/builder/boolean.rs:
##########
@@ -21,11 +21,29 @@ use std::ops::Range;
/// Builder for [`BooleanBuffer`]
///
+/// A `BooleanBufferBuilder` enables building a packed buffer of bits
+/// representing boolean values. Each bit in the buffer corresponds to a
boolean
+/// value,
+///
/// # See Also
///
-/// * [`NullBuffer`] for building [`BooleanBuffer`]s for representing nulls
Review Comment:
NullBufferBuilder is the correct reference so I fixed that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
