etseidl commented on code in PR #9155:
URL: https://github.com/apache/arrow-rs/pull/9155#discussion_r2688417328
##########
arrow-buffer/src/builder/null.rs:
##########
@@ -193,13 +196,22 @@ impl NullBufferBuilder {
}
}
- /// Builds the null buffer and resets the builder.
- /// Returns `None` if the builder only contains `true`s.
+ /// Builds the [`NullBuffer`] and resets the builder.
+ ///
+ /// Returns `None` if the builder only contains `true`s. Use
[`Self::build`]
+ /// when you don't need to reuse this builder.
pub fn finish(&mut self) -> Option<NullBuffer> {
self.len = 0;
Some(NullBuffer::new(self.bitmap_builder.take()?.finish()))
Review Comment:
```suggestion
Some(NullBuffer::new(self.bitmap_builder.take()?.build()))
```
Since we've already taken ownership of `bitmap_builder`?
##########
arrow-buffer/src/builder/boolean.rs:
##########
@@ -247,14 +264,24 @@ impl BooleanBufferBuilder {
self.buffer.as_slice_mut()
}
- /// Creates a [`BooleanBuffer`]
+ /// Creates a [`BooleanBuffer`].
Review Comment:
```suggestion
/// Resets this builder and returns a [`BooleanBuffer`].
```
##########
arrow-buffer/src/builder/boolean.rs:
##########
@@ -247,14 +264,24 @@ impl BooleanBufferBuilder {
self.buffer.as_slice_mut()
}
- /// Creates a [`BooleanBuffer`]
+ /// Creates a [`BooleanBuffer`].
Review Comment:
echo the language from `BufferBuilder`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
