orlp commented on code in PR #633:
URL:
https://github.com/apache/arrow-rs-object-store/pull/633#discussion_r2758457570
##########
src/aws/checksum.rs:
##########
@@ -24,12 +24,15 @@ use std::str::FromStr;
pub enum Checksum {
/// SHA-256 algorithm.
SHA256,
+ /// CRC64-NVME algorithm.
+ CRC64NVME,
Review Comment:
This is *technically* a breaking change because this enum was (erroneously
IMO) not marked as `#[non_exhaustive]`. It's up to the maintainer - I
personally don't believe anyone is matching on `Checksum`.
But @kdn36 you should definitely mark this enum as `#[non_exhaustive]`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
