alamb commented on code in PR #633:
URL: 
https://github.com/apache/arrow-rs-object-store/pull/633#discussion_r2769997473


##########
src/aws/checksum.rs:
##########
@@ -24,12 +24,15 @@ use std::str::FromStr;
 pub enum Checksum {

Review Comment:
   If we are going to change the enum, perhaps we can add all the other 
supported checksums as well (we don't have to actually support them, but we can 
minimize API churn)
   
   
   I think that would mean adding the following variants (with comments that 
they aren't yet supported)
   
   CRC32
   CRC32C
   SHA1
   MD5



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to