orlp commented on code in PR #633:
URL:
https://github.com/apache/arrow-rs-object-store/pull/633#discussion_r2770278559
##########
src/aws/checksum.rs:
##########
@@ -24,12 +24,15 @@ use std::str::FromStr;
pub enum Checksum {
Review Comment:
@alamb If the enum is marked as `#[non_exhaustive]` as I recommended above
then adding new variants isn't a breaking change. I personally don't think it's
a good idea to add variants which aren't actually supported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
