kou commented on code in PR #48934:
URL: https://github.com/apache/arrow/pull/48934#discussion_r2766682626
##########
dev/release/05-binary-upload.sh:
##########
Review Comment:
Could you revert needless permission change?
##########
dev/release/04-binary-download.sh:
##########
Review Comment:
Could you revert needless permission change?
##########
dev/release/05-binary-upload.sh:
##########
@@ -108,6 +109,10 @@ upload_to_github_release() {
if [ "${UPLOAD_DOCS}" -gt 0 ]; then
upload_to_github_release docs "${ARROW_ARTIFACTS_DIR}"/*-docs/*
fi
+if [ "${UPLOAD_ODBC}" -gt 0 ]; then
+ upload_to_github_release odbc \
+ "${ARROW_ARTIFACTS_DIR}"/"Apache-Arrow-Flight-SQL-ODBC"-*-win64.msi
Review Comment:
Let's remove needless quotes.
```suggestion
"${ARROW_ARTIFACTS_DIR}"/Apache-Arrow-Flight-SQL-ODBC-*-win64.msi
```
##########
dev/release/05-binary-upload.sh:
##########
Review Comment:
`05-binary-upload.sh` is executed by a PMC member but all Apache Arrow
contributors can update `05-binary-upload.sh`. Could you implement MSI signing
in this PR because it's related to the official MSI.
##########
.github/workflows/cpp_extra.yml:
##########
@@ -478,6 +480,59 @@ jobs:
remote_key: ${{ secrets.NIGHTLIES_RSYNC_KEY }}
remote_host_key: ${{ secrets.NIGHTLIES_RSYNC_HOST_KEY }}
+ odbc-check-tags:
Review Comment:
If `*-rc*` feels loose, we can use `contains(github.ref_name,
'apache-arrow-*-rc*`)`. I want to keep GitHub Actions configuration as much as
simple for easy to maintain. So I want to remove this `odbc-check-tags` step if
possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
