alinaliBQ commented on code in PR #48934:
URL: https://github.com/apache/arrow/pull/48934#discussion_r2771325121
##########
dev/release/05-binary-upload.sh:
##########
@@ -108,6 +109,10 @@ upload_to_github_release() {
if [ "${UPLOAD_DOCS}" -gt 0 ]; then
upload_to_github_release docs "${ARROW_ARTIFACTS_DIR}"/*-docs/*
fi
+if [ "${UPLOAD_ODBC}" -gt 0 ]; then
+ upload_to_github_release odbc \
+ "${ARROW_ARTIFACTS_DIR}"/"Apache-Arrow-Flight-SQL-ODBC"-*-win64.msi
Review Comment:
Sure, done
##########
.github/workflows/cpp_extra.yml:
##########
@@ -478,6 +480,59 @@ jobs:
remote_key: ${{ secrets.NIGHTLIES_RSYNC_KEY }}
remote_host_key: ${{ secrets.NIGHTLIES_RSYNC_HOST_KEY }}
+ odbc-check-tags:
Review Comment:
Totally understandable. As a workaround, I have changed the approach to use
```
if: ${{ startsWith(github.ref_name, 'apache-arrow-') &&
contains(github.ref_name, '-rc') }}
```
Please note that this check can pick up `'apache-arrow-rc'` tag.
I have tried `contains(github.ref_name, 'apache-arrow-*-rc*')` and it didn't
work, I think `contains()` doesn't support regex or wild card checks.
##########
dev/release/05-binary-upload.sh:
##########
Review Comment:
Yup, I reverted it. it was changed accidentally
##########
dev/release/04-binary-download.sh:
##########
Review Comment:
Yup, I reverted it. it was changed accidentally
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
